[sddm-theme] Remove login screen blur effect
AbandonedPublic

Authored by rooty on Feb 26 2019, 8:42 PM.

Details

Reviewers
filipf
ngraham
davidedmundson
Group Reviewers
VDG
Plasma
Summary

This patch removes the login screen blur effect.

Test Plan

Before:


After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
no-more-blur (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8905
Build 8923: arc lint + arc unit
rooty created this revision.Feb 26 2019, 8:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 26 2019, 8:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Feb 26 2019, 8:42 PM
rooty edited the summary of this revision. (Show Details)Feb 26 2019, 8:43 PM
rooty edited the test plan for this revision. (Show Details)
rooty added reviewers: VDG, Plasma, filipf, ngraham.
ngraham requested changes to this revision.EditedFeb 26 2019, 9:15 PM

In addition to just the WallpaperFader, you'll also need to remove all the multi-state plumbing too: the mouseArea, the animated transitions, the uiVisible variable, etc. You'll also need to figure out a way to make the icon buttons and their white labels on the bottom edge of the screen not become illegible against white or very busy backgrounds.

You can see the approach I tried for these issues in D16031.

FWIW I originally used different separate patches to try various approaches for the bottom bar and the ActionButtons, but in the end I put them all into the same patch because they were an inseparable part of the remove-the-blur change and couldn't stand alone. You might want to consider doing the same thing here, or else you'll go through an endless nightmare of rebasing patches over and over again. :)

This revision now requires changes to proceed.Feb 26 2019, 9:15 PM
rooty updated this revision to Diff 52684.Feb 26 2019, 9:43 PM
rooty edited the test plan for this revision. (Show Details)

Clean up some more

Almost there!

sddm-theme/Main.qml
136

I'm not sure this removal is necessary or related to this patch. We might be able to remove it anyway, if its fixed in 0.14 like the comment says, but that should be in a different patch.

rooty marked an inline comment as done.Feb 27 2019, 7:20 PM
rooty added inline comments.
sddm-theme/Main.qml
136

ok

rooty updated this revision to Diff 52766.Feb 27 2019, 7:23 PM
rooty marked 2 inline comments as done.

Bring back timer

rooty added a comment.Feb 27 2019, 7:23 PM

Bring back timer

Better?

ngraham accepted this revision.Feb 27 2019, 7:30 PM

Yep, looks great now! Let's wait to land this until all the dependent patches are approved too.

This revision is now accepted and ready to land.Feb 27 2019, 7:30 PM
rooty added a comment.Feb 27 2019, 7:33 PM

Yep, looks great now! Let's wait to land this until all the dependent patches are approved too.

Sure thing

davidedmundson requested changes to this revision.Feb 27 2019, 7:46 PM
davidedmundson added a subscriber: davidedmundson.

This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that.

This revision now requires changes to proceed.Feb 27 2019, 7:46 PM
rooty added a comment.Feb 27 2019, 8:02 PM

This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that.

I can't believe I'm going to walk back my original argument from about a year ago but... yes it does, it makes it different but doesn't introduce inconsistency, at least not necessarily (because the design remains the same).

On the lock screen, the wallpaper fader serves a distinct purpose - to obscure the lock screen (clock + wallpaper) in order to make the user focus on password entry.

On the login screen, I'm not so sure - there's no lock screen to obscure, and the user login is the primary purpose, so all the wallpaper fader seems to do is obscure the wallpaper (which makes you wonder what's the point of having a wallpaper anyway?)


That being said, if you're intent on keeping the blur, I suggest tweaking the wallpaper fader (so the amount of blur/gray goes down). And in that case, I also suggest removing all the shadows except for the ones on (under?) the clock.

rooty added a comment.EditedFeb 27 2019, 8:08 PM

P.S. @davidedmundson I know this may not be the place to ask this, regarding the blur/wallpaper fader, would it be possible to implement the changes from D18377 in the wallpaper fader? Is that something I could/should file a report with Qt for?

RE: blur

To do it the same way that patch did it in the end (Using sRGB textures) would require a Qt patch. That would magically fix all shaders. I've not tried, but it certainly looks feasible.
(Patch QSGMaterial to have a flag to push/pop GL_FRAMEBUFFER_SRGB) then patch QQuickOpenGlShaderEffect.cpp then add an option in QQuickShaderEffect)

Alternatively:
We could copy and paste the FastBlur and square the fragment colours locally.

RE: blur

To do it the same way that patch did it in the end (Using sRGB textures) would require a Qt patch. That would magically fix all shaders. I've not tried, but it certainly looks feasible.
(Patch QSGMaterial to have a flag to push/pop GL_FRAMEBUFFER_SRGB) then patch QQuickOpenGlShaderEffect.cpp then add an option in QQuickShaderEffect)

Alternatively:
We could copy and paste the FastBlur and square the fragment colours locally.

Sounds good! Way over my head but :D I like the idea of using sRGB in Qt as well.

P.S. It just occurred to me - if we kept the blur (and tweaked it a little) and used the same sddm background on the splash screen, we could get a "deblur as you unlock" effect.
Even better, if the user should decide to use the same background on the login screen, the splash screen and their desktop, the login could end up looking really nice and seamless.

This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that.

I don't think this is applicable since the lock screen is already different from the login screen.

The objections driving this proposal are that the heavily darkened blur effect is kind of ugly, and that the wallpaper itself is indistinct and obscured, negating the entire purpose of putting a wallpaper there in the first place. That said, I kind of like @rooty's idea of keeping the blur but reducing its strength, and then un-blurring it on login and having the Breeze splash screen always show the un-blurred version of the wallpaper chosen for the SDDM theme. This would solve the problem of people being unable to see the wallpaper image, while preserving the legibility benefits of the blur.

If it's technically possible, this might be a compromise we can all agree on.

This makes it different to the lock screen. I said in the last patch that did this that we shouldn't do that.

I don't think this is applicable since the lock screen is already different from the login screen.

The objections driving this proposal are that the heavily darkened blur effect is kind of ugly, and that the wallpaper itself is indistinct and obscured, negating the entire purpose of putting a wallpaper there in the first place. That said, I kind of like @rooty's idea of keeping the blur but reducing its strength, and then un-blurring it on login and having the Breeze splash screen always show the un-blurred version of the wallpaper chosen for the SDDM theme. This would solve the problem of people being unable to see the wallpaper image, while preserving the legibility benefits of the blur.

If it's technically possible, this might be a compromise we can all agree on.

How's this for a really early draft?
Before:


After:

Much prettier than the current blur!

rooty added a comment.Feb 28 2019, 7:22 AM

Much prettier than the current blur!

Thanks, the transition is pretty awesome too now that the blur's less dim

rooty abandoned this revision.Mar 2 2019, 4:39 AM