I never landed a diff before because I just got my KDE developer account.
Few general questions:

• Is it enough that one reviewer accept the revision, or all the listed ones should accept it? (or depends on the project?)
• Can I directly land it once the condition above is satisfied, or is it always better to ask before landing it?

In D19312#421632, @simgunz wrote:

I never landed a diff before because I just got my KDE developer account.
Few general questions:

• Is it enough that one reviewer accept the revision, or all the listed ones should accept it? (or depends on the project?)
• Can I directly land it once the condition above is satisfied, or is it always better to ask before landing it?

There's no official set of rules, but here are the conventions I try to follow:

• When group reviewers are specified, don't land the patch until all of them show an "Approved" status. If it's a relatively minor and uncontroversial patch, it may be acceptable to land after just one has accepted
• If the patch is at all complicated or controversial, don't land it until the maintainer of the project has an "Approved" status
• If it's a minor change to a string, or an uncontroversial bugfix to a visual issue, and the VDG group was specified as a group reviewer, and that group has an "Approved" status, that's enough

In this case I'd say you're clear to land it!

@ngraham Thanks for the guidelines

I landed it, and it seems I have not messed up anything.