Improve Unity Indicator
ClosedPublic

Authored by trmdi on Feb 25 2019, 5:11 PM.

Details

Summary
  • Fix the bug "UnityRect is smaller than the icon in some cases", caused by anchors.margin: 4
  • Do not use plasma colors for isActive or inAttention cases.

Diff Detail

Repository
R878 Latte Dock
Lint
Lint Skipped
Unit
Unit Tests Skipped
trmdi created this revision.Feb 25 2019, 5:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 25 2019, 5:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Feb 25 2019, 5:11 PM
mvourlakos accepted this revision.Feb 25 2019, 5:26 PM
This revision is now accepted and ready to land.Feb 25 2019, 5:26 PM

@trmdi do you have commit access?

If not you can apply for one and you can reference me

trmdi added a comment.Mar 3 2019, 5:20 AM

@trmdi do you have commit access?

If not you can apply for one and you can reference me

I tried it, but not sure if/when they will accept it.
So could you please land this for me? :)

This revision was automatically updated to reflect the committed changes.