send a signal over dbus when the wrong password is provided

Authored by mart on Feb 25 2019, 4:11 PM.



On Plasma Mobile we can't actually show a qwidgets based dialog
when the password is wrong, and preferably not any additional window over the $
this adds a signal to the kded when it fails to authenticate,
the handler will forget such password so that the password field will appear again and the kcm shows an error message when this happens

Test Plan

tried to connect with wrong password

Diff Detail

R116 Plasma Network Management Applet
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Feb 25 2019, 4:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 25 2019, 4:11 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Feb 25 2019, 4:11 PM
mart added a reviewer: bshah.Feb 25 2019, 4:12 PM
jgrulich accepted this revision.Mar 2 2019, 8:14 PM

Good idea to remove the failed connection.


I'm not sure this assumption is currect, it's not that the password is wrong all the time, NM might be just asking for additional passwords or for passwords which are marked not to be stored (e.g. VPN, or WPA2 EAP). But I guess for your usecase we can leave it as it is, we just need to make sure that Configuration::showPasswordDialog() will be true only on plasma-mobile.


void secretAgentError(const QString &connectionPath, const QString &message)

so we know on first look what are these params?

This revision is now accepted and ready to land.Mar 2 2019, 8:14 PM
This revision was automatically updated to reflect the committed changes.