Use Kirigami.ActionTextField for the SearchField
ClosedPublic

Authored by ognarb on Mon, Feb 25, 1:03 PM.

Details

Summary

Need Kirigami latest version (master)

Test Plan

A regression found (need D19300)

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Mon, Feb 25, 1:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Feb 25, 1:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Mon, Feb 25, 1:03 PM
apol added a subscriber: apol.Mon, Feb 25, 1:58 PM
apol added inline comments.
discover/qml/SearchField.qml
33

visible: root.text.length !== 0

34

searchField.clearText()

ognarb updated this revision to Diff 52533.Mon, Feb 25, 2:23 PM
ognarb marked 2 inline comments as done.

Improve code

ngraham accepted this revision.Mon, Feb 25, 2:40 PM
ngraham added a subscriber: ngraham.

Thanks! Next can you do System Settings? https://cgit.kde.org/systemsettings.git/tree/sidebar/package/contents/ui/CategoriesPage.qml#n53

Looks like that one has some RTL handling that maybe could be upstreamed into ActionToolbar too.

This revision is now accepted and ready to land.Mon, Feb 25, 2:40 PM
This revision was automatically updated to reflect the committed changes.

Also it would be nice to port Discover itself to use this.

Also it would be nice to port Discover itself to use this.

I'm not sure, I understand your comment. What do you mean with this? Discover already implement the actionSearchField.

Oops, so it does!