Differential D19300

Improve ToolTip in the ActionTextField component
ClosedPublic
Actions

Authored by ognarb on Feb 25 2019, 12:51 PM.

Details

Reviewers
ngraham
Group Reviewers
Kirigami
Commits
R169:e0503e1794b5: Improve ToolTip in the ActionTextField component
Summary
  • Add standard duration (Kirigami.Units)
  • Don't display when text is not empty (same behaviour as in Discover)
Test Plan

Manually tooltip appear when not text is present and doesn't appere when text is present

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Feb 25 2019, 12:51 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 25 2019, 12:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Feb 25 2019, 12:51 PM
ngraham accepted this revision.Feb 25 2019, 2:36 PM
ngraham added a subscriber: ngraham.

Thanks!

This revision is now accepted and ready to land.Feb 25 2019, 2:36 PM
Closed by commit R169:e0503e1794b5: Improve ToolTip in the ActionTextField component (authored by ognarb). · Explain WhyFeb 25 2019, 3:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/ActionTextField.qml (3 lines)

Diff 52536

View Options

src/controls/ActionTextField.qml

Loading...