This patch ports most of the QQC1 elements into QQC2 and makes use of Kirigami.FormLayout.
Due to an overwhelming number of options originally being present, the patch also splits them up
into "Appearance" and "Behavior" categories.
ngraham | |
rooty | |
GB_2 | |
hein |
Plasma | |
VDG |
This patch ports most of the QQC1 elements into QQC2 and makes use of Kirigami.FormLayout.
Due to an overwhelming number of options originally being present, the patch also splits them up
into "Appearance" and "Behavior" categories.
No Linters Available |
No Unit Test Coverage |
Buildable 8779 | |
Build 8797: arc lint + arc unit |
Use action verbs for "Sorting" and "Grouping"; extend "visible: vertical" property to all
revelant elements
I love the idea of an Appearance/Behavior split. I think that really improves the approachability of the settings window. But I think it will require a bit of re-organization since with the current state of the patch, there are items on the Behavior page that are appearance-based, and vice versa.
How about this for the breakdown?
Appearance General: [x] Show tooltips [ ] Highlight windows [x] Show progress and status information in task buttons [x] Mark applications that play audio Icon size: --------------o----------- Small Large Maximum rows: [ 2 ] [x] Always arrange tasks in as many rows as columns
Behavior Group: [ By program name v ] [x] Open groups in popups [x] Only when the Task Manager is full Sort: [ Manually v ] [x] Keep launchers separate On middle-click: [ Close Window or Group v ] [ ] Cycle through tasks with mouse wheel Filters: [ ] Show only tasks from the current screen [ ] Show only tasks from the current desktop [x] Show only tasks from the current activity [ ] Show only tasks that are minimized
applets/taskmanager/package/contents/ui/ConfigAppearance.qml | ||
---|---|---|
57 | This would be a bit clearer if it said something more along the line of "Highlight windows when hovering over tasks" |
"Filters:" -> "Filter:", "Only when the Task Manager is full" -> "Group only when the Task
Manager is full" (I think it's better to be explicit), use "preferences-desktop-color" for
Appearance icon, "Highlight windows" -> "Highlight windows when hovering over tasks"
Thank you :)
Does anyone from Plasma maybe know why the QQC2 Slider fails to obey the "visible: vertical" setting? The variables have been changed in accordance with QQC2 and the slider does show up with no "visible:" status set, but simply won't work here.
- Open groups in popups
- Only when the Task Manager is full
Reversing and not indenting these options breaks their dependent relationship. Please revert this to the original layout.
Looks nice otherwise!
applets/taskmanager/package/contents/ui/ConfigBehavior.qml | ||
---|---|---|
70 | Wait, 10x the checkbox width? |
applets/taskmanager/package/contents/ui/ConfigBehavior.qml | ||
---|---|---|
70 | Should be units.largeSpacing |
applets/taskmanager/package/contents/ui/ConfigBehavior.qml | ||
---|---|---|
70 | I tried units.largeSpacing first then realized it's not aligned with the top text (not even with 1.0 scaling) so I did something like (units.largeSpacing - units.smallSpacing * 2) which worked ok with 1.0 scaling but the higher the scaling factor the more the text shifted to the right = it stopped being aligned with the top text. This bad code that's present now worked well with all scaling preferences. I can just do units.largeSpacing though if everyone is fine with that. |
applets/taskmanager/package/contents/ui/ConfigBehavior.qml | ||
---|---|---|
70 | units.largeSpacing is correct and used in other places too. |
use units.largeSpacing for indentation; remove redunant visible: vertical properties for children
of RowLayout
rename "vertical" property to "plasmoidVertical" because it was interfering with QQC2's slider
"vertical" variable; use QQC2 slider
Shoutout to @GB_2 for figuring out why the QQC2 slider didn't work. Hopefully everything is fine now.
applets/taskmanager/package/contents/ui/ConfigAppearance.qml | ||
---|---|---|
22 | Import is not needed anymore. |
applets/taskmanager/package/contents/ui/ConfigAppearance.qml | ||
---|---|---|
22 | Yes it is, there's a RowLayout in here. |
applets/taskmanager/package/contents/ui/ConfigAppearance.qml | ||
---|---|---|
22 | I meant the QQC1 import, but it was removed just before I posted this comment :P |
Indentation looks good! Looks great and works great for both regular and icons-only task managers, in both horizontal and vertical orientations.
Shipit!