[ConfigCategoryDelegate] Add horizontal padding to the label
ClosedPublic

Authored by filipf on Sun, Feb 24, 2:55 PM.

Details

Summary

This patch adds horizontal padding to the category configuration delegate so that the label does not look like it is glued to the parent element.

Test Plan

Before:

After:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Sun, Feb 24, 2:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Feb 24, 2:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Sun, Feb 24, 2:55 PM
filipf edited the summary of this revision. (Show Details)Sun, Feb 24, 2:55 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG, ngraham.
rooty added a subscriber: rooty.Sun, Feb 24, 2:58 PM

you got my vote, i think this looks a lot less stuck-on

ngraham accepted this revision.Sun, Feb 24, 3:17 PM

Conceptually sound. I'd say this even is a bugfix that can land on the Plasma/5.15 branch, if the Plasma folks agree. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

This revision is now accepted and ready to land.Sun, Feb 24, 3:17 PM
filipf added a comment.Fri, Mar 1, 3:34 PM

Any more thoughts on this?

I'd say go for it. :)

davidedmundson accepted this revision.Fri, Mar 1, 5:21 PM
davidedmundson added a subscriber: davidedmundson.

You can merge to 5.15 if you want.

This revision was automatically updated to reflect the committed changes.