Differential D19234

Use new video camera icon
ClosedPublic
Actions

Authored by ngraham on Feb 22 2019, 8:53 PM.

Details

Reviewers
apol
filipf
rooty
Group Reviewers
VDG
Commits
R474:23a080e17022: Use new video camera icon
R474:2920cea2cb00: Merge branch 'Applications/18.12'
Summary

A new video camera icons was added in D18986. Let's use it in Kamoso!

This requires bumping the frameworks dependency to 5.56, since that's the release
that includes the new camera icon.

Test Plan

Diff Detail

Repository
R474 Kamoso
Branch
use-new-camera-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8709
Build 8727: arc lint + arc unit
ngraham requested review of this revision.Feb 22 2019, 8:53 PM
ngraham created this revision.
filipf accepted this revision.Feb 23 2019, 12:00 AM
filipf added a subscriber: filipf.

Looks good and is more appropriate than the old icon:

This revision is now accepted and ready to land.Feb 23 2019, 12:00 AM
rooty accepted this revision.Feb 23 2019, 12:33 AM
ngraham added a comment.Feb 23 2019, 3:43 AM

Thanks guys.

@apol, are you okay with bumping the KF5 dependency in order to use this icon?

apol accepted this revision.Feb 23 2019, 11:48 PM

Removing it from the repository won't make it work for users who don't use breeze? LGTM in general.

ngraham added a comment.Feb 24 2019, 5:15 AM

Many other icon themes have this icon already. We were the late ones, in fact. :)

Closed by commit R474:23a080e17022: Use new video camera icon (authored by ngraham). · Explain WhyFeb 24 2019, 5:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52340

View Options

CMakeLists.txt

Loading...
View Options

icons/CMakeLists.txt

Loading...
View Options

icons/sc-actions-record.svgz

Loading...
View Options

src/qml/Main.qml

Loading...