[wayland] Keep application startup flow inside main_wayland

Authored by davidedmundson on Feb 22 2019, 6:54 PM.



In a recent patch the newly added xwayland class ended up being
responsible for continuing the startup, calling back into the main app
to spawn the workspace.

It moves the flow of startup about so it's not very readable or
following class structure.

This patch moves the code back into main_wayland and removes the
duplication between xwayland and non-xwayland modes.

There was also a misnaming of methods.

continueStartupWithScreens was called after platform screens are created
continueStartupWithScene was called after the scene was created
continueStartupWithXwayland was called before xwayland is created

This was confusing, so the names have been shuffled around to follow a
consistent pattern of what has been done so far.

Test Plan

Started kwin_wayland in normal and xwayland mode
Ran unit tests (though some failed due to a local unrelated and as yet unindentified bug)

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Feb 22 2019, 6:54 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 22 2019, 6:54 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Feb 22 2019, 6:54 PM
romangg accepted this revision.Feb 22 2019, 10:43 PM
romangg added a subscriber: romangg.

Nicely structured. Great!

This revision is now accepted and ready to land.Feb 22 2019, 10:43 PM
This revision was automatically updated to reflect the committed changes.