[about-distro] let distributions choose VERSION_ID or VERSION
ClosedPublic

Authored by sitter on Feb 22 2019, 1:56 PM.

Details

Summary

by default we display VERSION_ID because it is the pure numeric
representation while VERSION may contain all sorts of clutter information
that overloads the KCM and possibly makes the KCM look ugly.
but, VERSION is technically meant for displaying to the user, so there
is a reason why a distribution may choose to display that instead of the
ID.

to give them control over this there's now a bool config entry
UseOSReleaseVersion which defaults to false, when set to true the KCM
will use the VERSION instead of VERSION_ID.

Test Plan
  • VERSION and VERSION_ID are different
  • config value not set
  • kcm uses VERSION_ID
  • config value set to true
  • kcm uses VERSION

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 22 2019, 1:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 22 2019, 1:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Feb 22 2019, 1:56 PM
apol accepted this revision.Feb 22 2019, 1:58 PM
This revision is now accepted and ready to land.Feb 22 2019, 1:58 PM
This revision was automatically updated to reflect the committed changes.