Install DefinitionDownloader header
ClosedPublic

Authored by davschul on Feb 22 2019, 7:10 AM.

Details

Summary

Makes it possible to use the exported definition downloader from an installed
syntax highlighting engine.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
davschul created this revision.Feb 22 2019, 7:10 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 22 2019, 7:10 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
davschul requested review of this revision.Feb 22 2019, 7:10 AM

I would have no issues with this if Volker is ok, too.

I also do not see an issue with this.

But I would like to add some background info that may be interesting: Downloading the syntax highlighting files will download all files, and not just the ones that changed etc. This by itself is fine, since it guarantees consistency with highlighting files that include each other with the IncludeRules rule. However, with downloading you'll get almost 300 .xml files that need to be checked for version info etc... That may be slow (and in fact one of the reasons why we compile in the files as Qt resource). That said, if you open a file that uses KSyntaxHighlighting, you may experience several hundred milliseconds of delay when the Repository instance is created.

I am just adding this as a "you should know what you are doing" info, since you probably want to avoid instanciating a Repository by default on application startup, since then Qt Creator would startup slower.

Besides that, no issues from my side, of course :-)

vkrause accepted this revision.Feb 24 2019, 6:43 PM
This revision is now accepted and ready to land.Feb 24 2019, 6:43 PM
This revision was automatically updated to reflect the committed changes.