Differential D19210

[Updates page] Try our best to not elide version strings
ClosedPublic
Actions

Authored by ngraham on Feb 21 2019, 10:32 PM.

Details

Reviewers
colomar
apol
Group Reviewers
Discover Software Store
Commits
R134:d2d33a20b0e0: [Updates page] Try our best to not elide version strings
Summary

With this patch, Discover will try its back to never elide version strings on the
Updates page. It will first fall back to a shorter squeezed string that only shows the
available version, then elide from the left so that the most important part doesn't get
cut off.

All of this is mostly only a problem on KDE Neon when using widescreen or mobile view,
but it's nice to fix anyway.

BUG: 404624
FIXED-IN: 5.15.2

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Branch
make-version-text-more-visible-in-limited-spaces (branched from Plasma/5.15)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8659
Build 8677: arc lint + arc unit
ngraham created this revision.Feb 21 2019, 10:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2019, 10:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 21 2019, 10:32 PM
ngraham edited the summary of this revision. (Show Details)Feb 21 2019, 10:33 PM
apol accepted this revision.Feb 21 2019, 11:37 PM
This revision is now accepted and ready to land.Feb 21 2019, 11:37 PM
Closed by commit R134:d2d33a20b0e0: [Updates page] Try our best to not elide version strings (authored by ngraham). · Explain WhyFeb 22 2019, 1:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/UpdatesPage.qml (18 lines)

Diff 52251

View Options

discover/qml/UpdatesPage.qml

Loading...