[sddm-kcm] Adjust Background label and button
ClosedPublic

Authored by GB_2 on Feb 21 2019, 7:33 PM.

Details

Summary

This patch adjusts the "Background:" label (adds padding and changes its alignment) and button to align with the changes implemented in D19077. It also moves the background preview button to below its corresponding label.

(P.S. The padding above the Background: label is controlled by patch D19077 for the most part.)

Test Plan

Before (with patch D19077 applied):


After (with patch D19077 applied):

For reference,
before (without patch D19077):


after (without patch D19077):

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Branch
bckgr-label-padding (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8662
Build 8680: arc lint + arc unit
rooty created this revision.Feb 21 2019, 7:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2019, 7:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Feb 21 2019, 7:33 PM
rooty edited the test plan for this revision. (Show Details)Feb 21 2019, 7:35 PM
rooty added reviewers: VDG, Plasma, filipf, ngraham.
rooty edited the summary of this revision. (Show Details)Feb 21 2019, 7:42 PM
rooty edited the summary of this revision. (Show Details)

Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper

Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper

Yes please!

Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper

I'm also in favor of this, it's a bit misleading. Good job aligning things!

rooty updated this revision to Diff 52256.Feb 21 2019, 11:07 PM

Remove "Customize theme" heading

rooty edited the test plan for this revision. (Show Details)Feb 21 2019, 11:08 PM
rooty abandoned this revision.Mar 28 2019, 11:20 PM
GB_2 added a subscriber: GB_2.Apr 4 2019, 3:40 PM
GB_2 added a comment.Apr 4 2019, 4:03 PM
This comment was removed by GB_2.
GB_2 added a reviewer: GB_2.Apr 4 2019, 4:16 PM
GB_2 added a comment.Apr 4 2019, 4:31 PM

@rooty Can you please reopen this?

filipf added a comment.EditedApr 4 2019, 8:24 PM
In D19209#443418, @GB_2 wrote:

@rooty Can you please reopen this?

He is not participating in KDE for the time being. You should commandeer the revision.

filipf updated this revision to Diff 55439.Apr 4 2019, 8:31 PM

attempt to allow for commandeering of the revision

GB_2 commandeered this revision.Apr 4 2019, 9:04 PM
GB_2 edited reviewers, added: rooty; removed: GB_2.

Ok, thanks.

GB_2 removed a reviewer: rooty.Apr 4 2019, 9:05 PM
GB_2 added a comment.Apr 6 2019, 12:48 PM

I think I can leave it how it is now.

filipf accepted this revision.Apr 8 2019, 5:16 PM
This revision is now accepted and ready to land.Apr 8 2019, 5:16 PM
GB_2 closed this revision.Apr 8 2019, 6:22 PM