| zzag | |
| davidedmundson |
| KWin |
Represent outputs in the X11 session via AbstractOutput. For that we
move all Wayland specific parts of AbstractOutput into a new subclass
AbstractWaylandOutput and let the outputs of our Wayland backends inherit
from there.
This should allow us to get rid of the Screens class later on.
Manually in X session.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I don't quite like that XRandRScreens::update() was moved to the platform code, but I guess we could revisit it later on.
| abstract_output.h | ||
|---|---|---|
| 5 | I think it should be "2018, 2019" | |
| autotests/CMakeLists.txt | ||
| 261–262 | No, I think we should keep the test. How about turning TestXRandRScreens into an integration test instead? | |
Could you please rebase this patch against master? (Qt 5.13 contains some breaking changes in QPA)
| autotests/CMakeLists.txt | ||
|---|---|---|
| 261–262 | After thinking for a while, I think there is no any value behind this test, so we could drop it. I still think that we need some tests to verify that KWin works correctly when an output gets added or removed, but this is completely unrelated to what this patch intends to achieve. | |
When rebasing I didn't notice implications by such changes. Maybe I overlooked them?
Some style nitpicks. Given how intrusive this change is please wait for another "Ship it" from KWin.
| plugins/platforms/x11/standalone/x11_platform.cpp | ||
|---|---|---|
| 38 | Coding style nitpick: this include directive should be below line 45, i.e. below #include "x11_decoration_renderer.h" | |
| plugins/platforms/x11/standalone/x11_platform.h | ||
| 108 | Coding style nitpick: missing whitespace between the asterisk and X11Output QVector<X11Output *> m_outputs; | |