Differential D19206

[Colors KCM] Fix color scheme editor context
ClosedPublic
Actions

Authored by broulik on Feb 21 2019, 6:02 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:5c879b258391: [Colors KCM] Fix color scheme editor context
Summary

Kirigami.Action has no parent

Test Plan

Classic case of "how could this have ever worked"

  • edited scheme, is now modal to the kcm again in kcmshell and systemsettings

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 21 2019, 6:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2019, 6:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 21 2019, 6:02 PM
broulik edited the test plan for this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Feb 21 2019, 6:15 PM
This revision is now accepted and ready to land.Feb 21 2019, 6:15 PM
Closed by commit R119:5c879b258391: [Colors KCM] Fix color scheme editor context (authored by broulik). · Explain WhyFeb 21 2019, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52225

View Options

kcms/colors/package/contents/ui/main.qml

Loading...