| davidedmundson | |
| dfaure |
Makes the API more complex, but it's worth it as it allows
knowledgable users to opt into avoding costly work and/or
data copies in very common use cases.
Significantly speeds up a lot of work in the models in the
presence of X apps that can't be identified and fall back to
the window icon.
Based on profiling by David.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| libtaskmanager/tasksmodel.cpp | ||
|---|---|---|
| 355–356 | Is IgnoreQueryItems still needed, now that both URLs are without icon data? (or could there potentially be other query items in the future?) | |
| libtaskmanager/xwindowtasksmodel.cpp | ||
| 656 | You could swap the two conditions, for a femto-second speed improvement in the common case. | |
Assume iconData is the only query item and, since the WithoutIcon
data role won't add it, avoid unnecessary calls to launcherUrlsMatch
and thus QUrl::adjusted.