KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H
ClosedPublic

Authored by loh.tar on Feb 21 2019, 4:51 AM.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Feb 21 2019, 4:51 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 21 2019, 4:51 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Feb 21 2019, 4:51 AM

For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached.

May try to fix that when got some +1

For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached.

I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731

Looks good to me - thanks.

dhaumann accepted this revision.Feb 23 2019, 8:16 PM
This revision is now accepted and ready to land.Feb 23 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.

For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached.

I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731

@dhaumann No comment to this? @cullmann May you?

I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731

@dhaumann No comment to this? @cullmann May you?

Yes, that is a good idea.
The only issue I see is that with Ctrl+H you don't have a clear starting point. Maybe the starting point should remain the same as long as the cursor position was not manually moved?

I guess it's just a matter of that no one implemented this.