| ptekchand |
Built with: craft kdiff3
With ABI = windows-msvc2017_64-cl
On Windows:
The leading "/" in the path via QUrl::fromLocalFile causes some
issues.
More details including callstacks and inline links to sources describing where certain transformations happen to introduce issues are described in https://github.com/KDE/kdiff3/pull/1
Repro:
Build and launch kdiff3 on Windows
Paste in two input files in the popped up input dialog for "A (BASE)" and "B"
Click OK to start the diff.
Without this patch, a "File open error" dialog pops up with "Opening of these files failed:" and the two source paths that were typed in.
Apply the patch, repeat the repro steps and notice that the files can be diffed successfully.
| Lint Skipped |
| Unit Tests Skipped |
Usually, if a url refers to local file (so isLocalFile() return true), then the right fix to get its local path is to use toLocalFile() instead of path().
Can you please try that change unconditionally?
I will switch to toLocalFile in any case as it is more correctly what I am
trying to accomplish here. Some how I missed that function. I definitely
prefer a non os specific fix if QTs API allows it. Let me know.
Update:
QUrl::path has been now been replaced with toLocalFile where appropriate.