Make it possible to show all spaces in the document
ClosedPublic

Authored by apol on Feb 19 2019, 4:10 PM.

Details

Summary

It's a feature offered by several editors. Now we allow to render none, only trailing and all of them.

BUG: 381267
BUG: 342811

Test Plan

Tested locally

Diff Detail

Repository
R39 KTextEditor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8700
Build 8718: arc lint + arc unit
apol created this revision.Feb 19 2019, 4:10 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 19 2019, 4:10 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
apol requested review of this revision.Feb 19 2019, 4:10 PM

I have wanted this for so long!

I like the feature, but for the implementation: Could we alter the config to itself hold the enum?
An other thing: why was the non-printable regex altered?

apol added a comment.Feb 21 2019, 11:34 PM

I like the feature, but for the implementation: Could we alter the config to itself hold the enum?

We could do that, I just didn't not to break currently existing systems

An other thing: why was the non-printable regex altered?

Was trying things and forgot to remove, it's gone now. Thanks!

In D19163#417139, @apol wrote:

I like the feature, but for the implementation: Could we alter the config to itself hold the enum?

We could do that, I just didn't not to break currently existing systems

I think it would be nicer to have it directly as enum in the config, otherwise in one year, we will be all confused how these two bools interact.

An other thing: why was the non-printable regex altered?

Was trying things and forgot to remove, it's gone now. Thanks!

No problem ;=)

apol updated this revision to Diff 52319.Feb 22 2019, 5:23 PM

Use an enum instead of two booleans

apol updated this revision to Diff 52320.Feb 22 2019, 5:25 PM

Fix tabs

cullmann accepted this revision.Feb 24 2019, 4:58 PM

I think that is ok now, thanks for the nifty feature.

This revision is now accepted and ready to land.Feb 24 2019, 4:58 PM
This revision was automatically updated to reflect the committed changes.