Add KAboutData
ClosedPublic

Authored by broulik on Feb 19 2019, 3:24 PM.

Details

Reviewers
sitter
Group Reviewers
Plasma
Commits
R122:972eb26d0558: Add KAboutData
Summary

Ensures correct app info is set, for example when crashing

Test Plan

send a SIGSEGV, now got "KDE Power Management System" has crashed.
Noticed that PowerDevil has its own versioning, currently 2.0.0, imho should just be using plasma version

Verified that stuff is still correctly translated

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 19 2019, 3:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 19 2019, 3:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 19 2019, 3:24 PM
broulik edited the test plan for this revision. (Show Details)
sitter accepted this revision.Feb 19 2019, 3:32 PM

LGTM

And FWIW I agree that following PROJECT_VERSION would be nicer.

This revision is now accepted and ready to land.Feb 19 2019, 3:32 PM
ngraham added inline comments.
daemon/powerdevilapp.cpp
69

That's a funny name. :)

This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Feb 21 2019, 7:43 PM
apol added inline comments.
daemon/powerdevilapp.cpp
69

PRobably doesn't make sense to translate names, no?