Differential D19158

[Runners] Use icon name
ClosedPublic
Actions

Authored by broulik on Feb 19 2019, 2:25 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R224:7970e3d1c428: [Runners] Use icon name
Summary

QIcon isn't thread-safe and here we just pass a theme icon name anyway, so we can have the runner UI do the work as needed.

Test Plan

Compiles

Diff Detail

Repository
R224 KDE Connect
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 19 2019, 2:25 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptFeb 19 2019, 2:25 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
broulik requested review of this revision.Feb 19 2019, 2:25 PM
nicolasfella accepted this revision.Feb 19 2019, 2:28 PM
This revision is now accepted and ready to land.Feb 19 2019, 2:28 PM
broulik added a comment.Feb 19 2019, 3:40 PM

Feel free to push, I can't.

nicolasfella closed this revision.Feb 21 2019, 10:53 AM

Revision Contents
Changeset List

Diff 52069

View Options

runners/findmyphone/findmyphonerunner.cpp

Loading...
View Options

runners/remotecommands/remotecommandsrunner.cpp

Loading...