Before, shadow size doubled with each new size until Very Large and the smaller shadows were more transparent than the larger shadows. Now shadow size increases linearly and smaller shadows start with more opacity so that they don't become nearly invisible. The new shadows should look better on cheap displays.
Not quite. Very Small is about the same size as the current Small (git master), but I did adjust the opacity to make it more visible. Small is now the same size as the current Medium, but with different opacity values. Medium is a new size that is between the current size and Large. Large is the same size with different opacity. Very Large is a bit smaller with different opacity. Smaller sizes start with more opacity than larger sizes to keep smaller sizes visible and to keep large sizes from being visually overpowering.
I kind of agree. I like the new size for Medium, and I think the default should maybe be a bit smaller (halfway between the current medium and the current large) but I also don't see the great value in adding more sizes. I think we can probably accomplish the visual goals we have in mind by tweaking the existing sizes to be less power-of-two-ey.
Small and Medium are the same sizes they originally were. Large is the same size that Medium was before this update to the revision. Very large is now the same size that Large was. I've also adjusted the starting opacity of the shadows a bit more.
Well, my concern was that now decoration shadows are way too black in comparison to kstyle shadows.
Also, I have a question about shadow that comes from directional light, why opacity decreases as size increases? Shouldn't it be vice versa?
I'm not an expert on this kind of thing, so I'm open to doing more modifications. I still don't really get how the ambient shadow works vs the directional one.
However, if an object casting a shadow is closer to the object in the shadow, the shadow will be darker and smaller than if the object casting the shadow is farther away.
Try it right now with two pieces of paper under a ceiling light.
Well, I guess that depends on the light. After all we don't try to model "physically correct" shadows.
Anyway, I've asked that question about opacity because most folks do the same thing. Also, this is what I did in kstyle. Even though kstyle and kdecoration shadows look different, I'd like to have the same "model" behind them. In general, I like the idea of decreasing shadow sizes to more saner values, but I'm not quite sure about new opacity values.
My thinking behind increasing opacity values was to keep darkness at some "constant" level, e.g. if you increase the blur radius, the darkness will be spreaded more, so to compensate that the opacity is increased.
But then we run into a problem where small shadows aren't visible enough to serve their purpose. How about we just get rid of different opacity for different shadow sizes and let the user control that with strength? Then we set the default strength to a value that we think is appropriate for the default shadow size.
Just increase opacity of shadow from ambient light. :-)
How about we just get rid of different opacity for different shadow sizes and let the user control that with strength? Then we set the default strength to a value that we think is appropriate for the default shadow size.
Most users don't spend their time on tweaking defaults.
On the one hand, it's true that the window shadows are now noticeably darker than KStyle shadows. On the other hand I'm not sure this is necessarily a problem. Ultimately the KStyle shadows are a largely an aesthetic matter, and don't present any problems of not being visible enough.
Then again, it might be nice to darken them even just a little bit to reduce the visual delta between them and the window decoration shadows. Especially with Breeze Dark, the KStyle shadows are still quite subtle:
Compare to regular Breeze:
Well, no, that's not that easy, we need them both. On its own, the directional shadow is a little bit harsh/sharp, so the ambient shadow is used to make it softer. Generally speaking, I took inspiration from material shadows. Pay close attention to pictures in "light and shadows" section.
TBH, I can't tell a difference between the old KStyle shadows and the new ones. Maybe I should have just left them as they were or maybe I should increase the opacity, but at least the numbers look pretty. ¯\_(ツ)_/¯
I don't see a difference either
If the ambient shadow actually did anything, wouldn't the inner areas of the shadow be significantly different in the second screenshot?
Again, I'll repeat, the ambient shadow matters. Decoration shadows are a bit bigger so it's okay to make it less subtle. Impact of the ambient shadow is more noticeable in kstyle shadows. Speaking of which, I'm not sure that I like the new ones. Popups "glow" rather than cast shadows; though that's personal(not anymore) opinion...
but at least the numbers look pretty.
The linear function is not good enough for sampling parameters. When I was working on shadows, I'd also fallen in this trap. "Pretty numbers" doesn't mean "pretty shadows." :-)