Fix context not disappearing from the treeview upon removal.
ClosedPublic
Actions

Authored by dfaure on Feb 19 2019, 12:04 AM.

Details

Reviewers

Commits

Summary

It turns out that Akonadi emits itemRemoved without any payload
in the item, while AkonadiFakeData was emitting full items.

So my wrong implementation in the LiveQueryIntegrator (which required
a payload) was working with fake data but not with real Akonadi.

Just comparing the item ID like we do for tasks and projects is much
simpler anyway.

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Feb 19 2019, 12:04 AM

dfaure created this revision.

reconstructItemDependencies is actually needed, say the tests

This revision is now accepted and ready to land.Mar 2 2019, 10:28 AM

push v2 (scripted)

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/akonadi/akonadilivequeryintegrator.h (2 lines)
M			src/akonadi/akonadiserializer.h (1 line)
M			src/akonadi/akonadiserializer.cpp (11 lines)
M			src/akonadi/akonadiserializerinterface.h (1 line)
M			tests/testlib/akonadifakedata.cpp (5 lines)
M			tests/units/akonadi/akonadiserializertest.cpp (25 lines)
M			tests/units/testlib/akonadifakedatatest.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52034	ac66cb7		Feb 19 2019, 12:04 AM	★	★
Diff 2	52289	3889ab8	reconstructItemDependencies is actually needed, say the tests	Feb 22 2019, 12:15 PM	★	★
Diff 3	52968	c8c80ca	push v2 (scripted)	Mar 2 2019, 12:30 PM	★	★
Diff 4	53002	d6e9748	R4:3d8849c402d447f2bfa55fdb24ae2189cc5deb14	Mar 2 2019, 3:56 PM	★	★