Store contexts as todos, not tags, step 7: fixing feature tests
ClosedPublic
Actions

Authored by dfaure on Feb 19 2019, 12:04 AM.

Details

Reviewers

ervin

Commits

Summary

ctest finally says:
100% tests passed, 0 tests failed out of 99

That doesn't mean the work is done. All it means is that any remaining
bugs will point to holes in the automated tests :-)

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Feb 19 2019, 12:04 AM

dfaure created this revision.

Admittedly I'm confused by some of the changes in the XML

tests/features/testenv/data/testdata.xml
83	Just removing it without inserting it in the VEVENT payload sounds wrong to me. At least it makes sure we don't look in VEVENTs
tests/units/akonadi/testenv/data/testdata.xml
166	ditto
205	ditto

This revision now requires changes to proceed.Mar 2 2019, 10:27 AM

tests/features/testenv/data/testdata.xml
83	Ah, hmm, OK, not that there's any chance of the CONTEXTLIST attribute ever getting into a VEVENT, unlike tags....
tests/units/akonadi/testenv/data/testdata.xml
205	Well, it's just completely unused, but OK, adding back, makes no difference to the tests.

push v2 (scripted)

Thanks, I like having dirty and broken data at places.

This revision is now accepted and ready to land.Mar 2 2019, 3:26 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/featurelib/zanshincontext.h (4 lines)
M			tests/featurelib/zanshincontext.cpp (46 lines)
M			tests/features/contexts/contextaddfeature.cpp (2 lines)
M			tests/features/testenv/data/testdata.xml (42 lines)
M			tests/testlib/akonadifakedata.cpp (1 line)
M			tests/testlib/akonadistoragetestbase.cpp (16 lines)
M			tests/units/akonadi/testenv/data/testdata.xml (46 lines)
M			tests/units/testlib/akonadifakedataxmlloadertest.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52033	1bbb00d		Feb 19 2019, 12:04 AM	★	★
Diff 2	52967	d812d5c	push v2 (scripted)	Mar 2 2019, 12:30 PM	★	★
Diff 3	53001	2815e62	R4:d6e9748cf652a0676f76111819cb41f5a033ad55	Mar 2 2019, 3:56 PM	★	★