Store contexts as todos, not tags, step 6: AkonadiFakeData
ClosedPublic

Authored by dfaure on Feb 19 2019, 12:03 AM.

Details

Summary

Port AkonadiFakeData from tags to context items

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Feb 19 2019, 12:03 AM
dfaure created this revision.
ervin requested changes to this revision.Mar 2 2019, 10:11 AM
ervin added inline comments.
src/akonadi/akonadistorage.cpp
47

I guess the three remaining includes about tags could go away as well, isn't it? Why isn't it happening now?

tests/testlib/akonadifakedata.h
92–93

Could have been the same in the caching part a couple of commits earlier btw. Would have avoided the odd comment now that I think of it.

tests/units/testlib/akonadifakedatatest.cpp
75–76

Remove the line instread of registering the type twice

This revision now requires changes to proceed.Mar 2 2019, 10:11 AM
dfaure added inline comments.Mar 2 2019, 11:56 AM
src/akonadi/akonadistorage.cpp
47

I could probably remove TagAttribute, but TagFetchJobInterface *Storage::fetchTags() is still there at that point. Don't worry, it all goes away in the end.

tests/testlib/akonadifakedata.h
92–93

OK, amended step5

tests/units/testlib/akonadifakedatatest.cpp
75–76

search/replace side effect ;)

Fixed.

dfaure updated this revision to Diff 52963.Mar 2 2019, 12:30 PM

push v2 (scripted)

ervin accepted this revision.Mar 2 2019, 3:25 PM
This revision is now accepted and ready to land.Mar 2 2019, 3:25 PM
This revision was automatically updated to reflect the committed changes.