Differential D19133

Mouse pointer broken with Qt 5.11.3
AcceptedPublic
Actions

Authored by Beuc on Feb 18 2019, 9:50 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

The new CMake test incorrectly flags Qt 5.11.3 as ">= 5.12".

This results in the mouse pointer not updating when on the canvas (typically keeps the horizontal sizer icon that it git from the nearest docker), transformation tool is unusable since there's no more rotate/shear/resize indicator (hopefully this isn't the case as well when actually using Qt 5.12, I didn't test).

This is for the krita/4.1 branch.

Test Plan
  • Compile from Debian Testing.
  • Look for "-- The following features have been disabled:// * Use Qt's XCB and Tablet support on X11, Do not use Krita's forked XCB connection and tablet support on X11, but leave everything to Qt." in the CMake log (means the test works correctly).

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
Beuc requested review of this revision.Feb 18 2019, 9:50 PM
Beuc created this revision.
rempt accepted this revision.Feb 18 2019, 10:03 PM
rempt added a subscriber: rempt.

Accepted, but yes, Qt 5.12 breaks our xcb implemenation and also breaks Krita if Qt's xcb is used. See

https://bugs.kde.org/show_bug.cgi?id=399664
https://bugs.kde.org/show_bug.cgi?id=399696

Maybe we should disable build with Qt 5.12 on Linux for 4.1 -- this isn't going to be fixed in the stable branch any time soon, it's way too complicated for that.

This revision is now accepted and ready to land.Feb 18 2019, 10:03 PM

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)

Diff 52013

View Options

CMakeLists.txt

Loading...