Use clang-tidy to:
- Use default when possible for constructor and destructor
- Use nullptr instead of 0 or NULL
- Use Q_DECL_OVERRIDE
if this patch is acepted, if will do the same for the entire calligra codebase.
leinir | |
danders |
Calligra: 3.0 |
Use clang-tidy to:
if this patch is acepted, if will do the same for the entire calligra codebase.
Compile and run
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Hmmm. wasn't it somethng with ms windows and for loops, leinir?
Also, I think there may be detachment issues with them, clazy can tell.
There is a qAsConst() solution but that is not supported in the qt version we need to support.
If there are issues, maybe drop the for loops for now.
There is an issue with Qt's foreach, however if the author would be so nice as to check that this version using C++11 iteration does not break building on Windows, then it can go in... Though, yes, it most certainly wants testing, and i don't currently have a functioning windows build system. 2890f2a929034d613c4b4a8f3e6ad77c23162d41 is one of the commits which did the q_foreach/for loop change previously, to see what actually got changed.
Ok, I can't say I have scrutinized every change, but...
Could you give a heads up when you continue with other parts or else there may be merge problems.
I'm working on karbon and pageapp atm, so please keep off :)
In D19132#416519, @danders wrote:Ok, I can't say I have scrutinized every change, but...
Could you give a heads up when you continue with other parts or else there may be merge problems.
I'm working on karbon and pageapp atm, so please keep off :)
Thanks for the review, I will work next on libs/{pigment,version,widgetutils}.
Thanks for the review, I will work next on libs/{pigment,version,widgetutils}.
Hmm, maybe wait with pigment, according to rempt, only krita actually used it.
I haven't looked into it, but if that is the case probably we should dump it.
Commit | Tree | Parents | Author | Summary | Date |
---|---|---|---|---|---|
e4f2cee745d5 | 9e52479dfde0 | 5496c486b51d | Carl Schwan | Update libs/widgets to c++11 (Show More…) | Feb 18 2019, 8:11 PM |