ApplicationPage: include the available version when selecting the source
ClosedPublic

Authored by apol on Mon, Feb 18, 3:41 PM.

Details

Summary

A source will often have different versions of the same software.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mon, Feb 18, 3:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Feb 18, 3:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Mon, Feb 18, 3:41 PM
ngraham requested changes to this revision.Mon, Feb 18, 3:50 PM
ngraham added a subscriber: ngraham.

This change would make the version number show up first in the string, assigning it primary visual importance. This would make the name of the dropdown menu ("Sources") incorrect.

I recommend the following format:

Flatpak (version 4.1)
Kubuntu (version 3.9.8)
etc.

Also, what if there is no version number available? We should handle that case too.

This revision now requires changes to proceed.Mon, Feb 18, 3:50 PM
apol added a comment.Mon, Mar 4, 1:32 AM

Can't add () because both sides add them.
I forgot to click submit on the screenshot last time (poor phab, was still offering it!), will add it now.

apol requested review of this revision.Mon, Mar 4, 1:33 AM
apol updated this revision to Diff 53094.Mon, Mar 4, 2:20 AM

swap order

ngraham accepted this revision.Mon, Mar 4, 4:00 AM

Ah, that makes sense. Looks good now!

This revision is now accepted and ready to land.Mon, Mar 4, 4:00 AM
This revision was automatically updated to reflect the committed changes.