Differential D19106

Use new display string function from KFileMetaData
ClosedPublic
Actions

Authored by astippich on Feb 17 2019, 8:14 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Baloo
Commits
R824:22e69f404100: Use new display string function from KFileMetaData
Summary

Remove all custom formatting function
in favor of the ones provided by KFileMetaData

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Feb 17 2019, 8:14 PM
Restricted Application added a project: Baloo. · View Herald TranscriptFeb 17 2019, 8:14 PM
astippich requested review of this revision.Feb 17 2019, 8:14 PM
astippich added a comment.Feb 17 2019, 8:16 PM

This can only be merged when it is okay that KDE applications can rely on KF 5.56

elvisangelaccio accepted this revision.Feb 19 2019, 9:08 PM
elvisangelaccio added a subscriber: elvisangelaccio.
elvisangelaccio added inline comments.
src/widgetfactory.cpp
129

QLatin1String is better for comparisons

This revision is now accepted and ready to land.Feb 19 2019, 9:08 PM
astippich updated this revision to Diff 52117.Feb 19 2019, 9:33 PM
  • use Qlatin1
Closed by commit R824:22e69f404100: Use new display string function from KFileMetaData (authored by astippich). · Explain WhyMar 1 2019, 10:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/widgetfactory.cpp (18 lines)

Diff 52891

View Options

CMakeLists.txt

Loading...
View Options

src/widgetfactory.cpp

Loading...