Delete all the custom formatting functions
and use the ones provided from KFileMetaData.
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:7a57be98126b: Use new display string function from KFileMetaData
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Awesome!
The Applications 19.04 dependency freeze is on March 14th, while frameworks 5.56 gets released on March 9th. I don't see a problem if you want to push this now (apart from the KDE CI which will probably need a rebuild of the Dependency Build job).
Thanks! Who should I ask for a dependency rebuild? sysadmin?
If you don't mind, please also have a look at D19106, which does the same for baloo-widgets. I'd like to land them at the same time for consistency.
@bcooksley I don't want to cause any build failures, what is the best way moving forward? Can I merge it now and somebody triggers a rebuild of the dependencies, or should I wait until Kf 5.56 is actually released?
You don't have to wait for a Frameworks release.
What you do need to wait for is a rebuild of the dependencies on the CI system. When did the companion commit to this land in KFileMetaData?
If it was before the dates mentioned at https://build.kde.org/job/Administration/ for Applications, then you're okay to commit.
Otherwise you'll need to wait for those jobs to have been re-run (looks like FreeBSD & Windows were about 4 days ago)
The commit is
https://phabricator.kde.org/R286:4bedfd6609c6efe5dc327d305feac8985d4658e3
from February 9, so it is safe to land, right?