Use new display string function from KFileMetaData
ClosedPublic

Authored by astippich on Feb 17 2019, 8:08 PM.

Details

Summary

Delete all the custom formatting functions
and use the ones provided from KFileMetaData.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Feb 17 2019, 8:08 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptFeb 17 2019, 8:08 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
astippich requested review of this revision.Feb 17 2019, 8:08 PM

This can of course only be merged when it is deemed okay to rely on KF 5.56

elvisangelaccio accepted this revision.Feb 17 2019, 9:04 PM
elvisangelaccio added a subscriber: elvisangelaccio.

Awesome!

The Applications 19.04 dependency freeze is on March 14th, while frameworks 5.56 gets released on March 9th. I don't see a problem if you want to push this now (apart from the KDE CI which will probably need a rebuild of the Dependency Build job).

This revision is now accepted and ready to land.Feb 17 2019, 9:04 PM

Thanks! Who should I ask for a dependency rebuild? sysadmin?
If you don't mind, please also have a look at D19106, which does the same for baloo-widgets. I'd like to land them at the same time for consistency.

Thanks! Who should I ask for a dependency rebuild? sysadmin?

I think anyone can do it, but yeah maybe better ask sysadmins

@bcooksley I don't want to cause any build failures, what is the best way moving forward? Can I merge it now and somebody triggers a rebuild of the dependencies, or should I wait until Kf 5.56 is actually released?

You don't have to wait for a Frameworks release.

What you do need to wait for is a rebuild of the dependencies on the CI system. When did the companion commit to this land in KFileMetaData?
If it was before the dates mentioned at https://build.kde.org/job/Administration/ for Applications, then you're okay to commit.

Otherwise you'll need to wait for those jobs to have been re-run (looks like FreeBSD & Windows were about 4 days ago)

The commit is
https://phabricator.kde.org/R286:4bedfd6609c6efe5dc327d305feac8985d4658e3
from February 9, so it is safe to land, right?

Yes, that is quite safe to land.

This revision was automatically updated to reflect the committed changes.