Search: Improve right-click context menu
ClosedPublic

Authored by abika on Feb 17 2019, 8:02 PM.

Details

Summary

Set pretty actions with shortcuts and signal/slot connections.

Panel: change KrView::getSelectedKrViewItems() from output parameter to normal return value

Search: Fix copy-to-clipboard action to only copy selected items

FIXED: [ 328918 ] Context menu item "copy selected to clipboard" copies all result items
BUG: 328918

Test Plan
  • tested all actions
  • tested actions disabled when result tab is not shown

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika requested review of this revision.Feb 17 2019, 8:02 PM
abika created this revision.
abika added a project: Krusader.

+1
Compiles, installs and works as expected.

nmel accepted this revision.Feb 18 2019, 7:50 AM
nmel added a subscriber: nmel.

Nice fix and improvement. Thanks!

This revision is now accepted and ready to land.Feb 18 2019, 7:50 AM
Closed by commit R167:764244391496: Merge branch 'my-search-context-menu' (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyFeb 24 2019, 5:07 PM
This revision was automatically updated to reflect the committed changes.
abika added a comment.Feb 24 2019, 5:08 PM

Thanks for the reviews!