Differential D19093

Improve the look of the Emoticons KCM UI
ClosedPublic
Actions

Authored by GB_2 on Feb 17 2019, 3:37 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
Commits
R119:8b413729da44: Improve the look of the Emoticons KCM UI
Summary

Apply the KDE HIG, make buttons consistent and make the KCM look better.

Test Plan

Open the Emoticons KCM.

Diff Detail

Repository
R119 Plasma Desktop
Branch
improve-look-of-emoticons-kcm-ui (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8435
Build 8453: arc lint + arc unit
GB_2 created this revision.Feb 17 2019, 3:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2019, 3:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 17 2019, 3:37 PM
GB_2 updated this revision to Diff 51905.Feb 17 2019, 3:44 PM

Fix resizing

ngraham added a subscriber: ngraham.Feb 17 2019, 6:29 PM

Awesome! Works great and looks so much better now. This new layout eliminates that horizontal scrollbar too.

Just a few little nitpicks.

kcms/emoticons/emoticonslist.ui
48

Start -> Create ?

ngraham added inline comments.Feb 17 2019, 6:43 PM
kcms/emoticons/emoticonslist.cpp
364

Shouldn't this use sentence case instead? Generally dialog boxes use sentence case for labels like this.

GB_2 updated this revision to Diff 51978.Feb 18 2019, 4:43 PM

Address comments

GB_2 marked 2 inline comments as done.Feb 18 2019, 4:44 PM
ngraham accepted this revision.Feb 18 2019, 4:59 PM

+1 shipit!

This revision is now accepted and ready to land.Feb 18 2019, 4:59 PM
Closed by commit R119:8b413729da44: Improve the look of the Emoticons KCM UI (authored by GB_2). · Explain WhyFeb 18 2019, 5:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51905

View Options

kcms/emoticons/emoticonslist.cpp

Loading...
View Options

kcms/emoticons/emoticonslist.ui

Loading...