Improve the look of the Emoticons KCM UI
ClosedPublic

Authored by GB_2 on Feb 17 2019, 3:37 PM.

Details

Summary

Apply the KDE HIG, make buttons consistent and make the KCM look better.

Test Plan

Open the Emoticons KCM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Feb 17 2019, 3:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2019, 3:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 17 2019, 3:37 PM
GB_2 updated this revision to Diff 51905.Feb 17 2019, 3:44 PM

Fix resizing

Awesome! Works great and looks so much better now. This new layout eliminates that horizontal scrollbar too.

Just a few little nitpicks.

kcms/emoticons/emoticonslist.ui
48

Start -> Create ?

ngraham added inline comments.Sun, Feb 17, 6:43 PM
kcms/emoticons/emoticonslist.cpp
364

Shouldn't this use sentence case instead? Generally dialog boxes use sentence case for labels like this.

GB_2 updated this revision to Diff 51978.Mon, Feb 18, 4:43 PM

Address comments

GB_2 marked 2 inline comments as done.Mon, Feb 18, 4:44 PM
ngraham accepted this revision.Mon, Feb 18, 4:59 PM

+1 shipit!

This revision is now accepted and ready to land.Mon, Feb 18, 4:59 PM
This revision was automatically updated to reflect the committed changes.