Add bison minimum version of 2.4.1 due to %code
ClosedPublic

Authored by hindenburg on Feb 17 2019, 3:16 PM.

Details

Summary

Some Mac OS versions have bison 2.3 even though it is very old.
%code is first handled in bison version 2.4; gnu site has 2.4.1 as
the earliest 2.4.x version.

Test Plan

Verified build fails in cmake phase when using bison 2.3 and builds
correctly using bison 2.4.1+.

Diff Detail

Repository
R309 KService
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hindenburg created this revision.Feb 17 2019, 3:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 17 2019, 3:16 PM
hindenburg requested review of this revision.Feb 17 2019, 3:16 PM
winterz accepted this revision.Mar 28 2019, 2:20 PM
winterz added a subscriber: winterz.

I'm for this.
I never created such a patch because I wasn't sure what minimum version was needed.

On Mac, what I do is install the homebrew bison and export PATH=/usr/local/opt/bison/bin:$PATH

I'd even be in favor of setting the minimum version to 3.0

This revision is now accepted and ready to land.Mar 28 2019, 2:20 PM

Is it OK to commit this now? It looks like the next tagging is April 6th

Not on the 19.04 branch, the dependency freeze happened few weeks ago - you may want to ask to release-team@ for an exception if you think it's important there too.

pino added a subscriber: pino.Mar 29 2019, 8:56 AM

Not on the 19.04 branch, ...

This is a Framework (kservice).

Ups, sorry! So according https://community.kde.org/Schedules/Frameworks there are no special provisions when the change doesn't touch translatable strings and the change is properly tested.

This revision was automatically updated to reflect the committed changes.