Differential D19090

Hardcoding the Remaining Time Update Interval
ClosedPublic
Actions

Authored by narvaez on Feb 17 2019, 12:23 PM.

Details

Reviewers
bruns
Group Reviewers
Baloo
Commits
R293:a3d188108960: Hardcoding the Remaining Time Update Interval
Summary

There is no relation between this number and the batch size of the
scheduler.

Diff Detail

Repository
R293 Baloo
Branch
monitor_hardcoded_interval
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8430
Build 8448: arc lint + arc unit
narvaez created this revision.Feb 17 2019, 12:23 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFeb 17 2019, 12:23 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
narvaez requested review of this revision.Feb 17 2019, 12:23 PM
bruns accepted this revision.Feb 17 2019, 4:07 PM
This revision is now accepted and ready to land.Feb 17 2019, 4:07 PM
bruns added a comment.Feb 17 2019, 4:09 PM

Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time"

narvaez closed this revision.Feb 17 2019, 5:24 PM
narvaez added a comment.Feb 17 2019, 5:28 PM
In D19090#413998, @bruns wrote:

Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time"

Huh, I updated my local commit to use that recommendation but arc still landed the old commit message, sorry about that

ngraham added a subscriber: ngraham.Feb 17 2019, 5:30 PM

Arc uses the commit message in the web UI, not your local one. If you change the local commit message, you need to then send it up to the web UI with arc diff --edit --verbatim

See https://community.kde.org/Infrastructure/Phabricator#Updating_the_summary_of_the_Differential_from_the_local_Git_commit_message

Kinda convoluted and unintuitive, I know. :/

Revision Contents
Changeset List

PathPackages
Msrc/qml/experimental/monitor.cpp (2 lines)

Diff 51898

View Options

src/qml/experimental/monitor.cpp

Loading...