${EGL_INCLUDE_DIR} is the path up to 'egl.h' -- so the header is
${EGL_INCLUDE_DIR}/egl.h
The compile test on the other hand includes 'EGL/egl.h', so the path
that needs to be passed to the compile test is "${EGL_INCLUDE_DIR}/..".
Details
Details
- Reviewers
hausmann apol - Group Reviewers
Automotive FreeBSD - Commits
- R240:7c64db956829: Fix FindEGL
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?
Comment Actions
Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach.
Comment Actions
Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.
Comment Actions
Yeah, then it might actuayll work without redefining the path -- but in both cases we are kind of assuming that all install egl.h into a subdir called 'EGL'.
Comment Actions
If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/
Comment Actions
If anyone hits a cmake error about "/usr/include/EGL/EGL/egl.h" after updating ECM (e.g. in kwayland or plasma-framework), remove the cache in the builddir and rerun cmake. This commit is actually correct, it's just incompatible with existing caches.