[breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme
ClosedPublic

Authored by rooty on Feb 16 2019, 12:24 AM.

Details

Summary

This patch replaces the suspend, hibernate and switch user icons in the Breeze icon theme with the ones from system.svgz in patch D19020, so they're used throughout Plasma and not just in the sddm theme.

Test Plan

See D19020.

These icons work in Kickoff etc.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Feb 16 2019, 12:24 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 16 2019, 12:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
rooty requested review of this revision.Feb 16 2019, 12:24 AM
rooty edited the summary of this revision. (Show Details)Feb 16 2019, 12:27 AM
rooty edited the test plan for this revision. (Show Details)
rooty added reviewers: VDG, ngraham.

While you're at it, can you also replace system-switch-user in the Breeze icon theme with the much better version that's in the Breeze Plasma theme?

rooty added a comment.Feb 17 2019, 3:25 AM

Sure thing... I always did find that weird arrow over the user icon kind of weird

rooty updated this revision to Diff 51888.Feb 17 2019, 3:35 AM

Update system-switch-user with version from system.svgz

rooty retitled this revision from [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme to [breeze-icons] Implement new suspend hibernate and switch user icons in Breeze icon theme.Feb 17 2019, 3:35 AM
rooty edited the summary of this revision. (Show Details)
rooty retitled this revision from [breeze-icons] Implement new suspend hibernate and switch user icons in Breeze icon theme to [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme.
rooty added a comment.EditedFeb 17 2019, 3:46 AM

While you're at it, can you also replace system-switch-user in the Breeze icon theme with the much better version that's in the Breeze Plasma theme?

I'm so sorry, I didn't even notice before making the diff - there are two icons in the system.svgz (Breeze desktop theme) that look really similar:
"system-switch-user" (one user + arrow):


and "system-users" (two users):

I accidentally replaced system-switch-user in the icon theme with system-users (not system-switch-user) in the desktop theme.

Should I roll that back? Or should I make the appropriate modifications to "look and feel" so the Plasma theme would use the two user icon instead of the one user + arrow one?

Or how about this - should I add a U-turn arrow on top of the two users and fashion a new switch user icon?

rooty updated this revision to Diff 51889.Feb 17 2019, 3:51 AM

Use symbolic links instead (icons are already present)

rooty updated this revision to Diff 51910.Sun, Feb 17, 5:18 PM

Implement the newer versions of all three icons

rooty edited the test plan for this revision. (Show Details)Sun, Feb 17, 5:27 PM

The Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display:

We might need to simplify the icons for the small sizes and/or make the Zs bigger.

rooty updated this revision to Diff 51986.Mon, Feb 18, 6:24 PM

Resize 22 px switch user icon

rooty added a comment.Mon, Feb 18, 6:28 PM

The Zs look a bit small in Kickoff and especially Kicker when using a non-high-DPI display:

We might need to simplify the icons for the small sizes and/or make the Zs bigger.

What about just two (big) Z's?

ngraham added a comment.EditedMon, Feb 18, 6:28 PM

That could work, yeah. Give it a try!

Then again we want to be consistent with Plasma theme versions, so maybe the Zs should only change for the smaller icons

rooty added a comment.Mon, Feb 18, 6:29 PM

That could work, yeah. Give it a try!

22 px or 32 px too?

Because the 32 px version matches the desktop theme 32 px version as is

P.S. What about hibernate? I don't have that icon in Kickoff but other people might?

ngraham added a comment.EditedMon, Feb 18, 6:30 PM

Just for the smaller versions.

Yes, let's do Hibernate too.

rooty added a comment.EditedMon, Feb 18, 6:40 PM

I'm gonna edit system.svgz too, for consistency's sake

I could make the suspend Z's even bigger

Or they could all be a bit bigger, and the snowflake versions could simply take up a teensy bit more of the snowflake's top-right corner.

rooty updated this revision to Diff 51996.Mon, Feb 18, 7:07 PM

Make all the Z's bigger

rooty added a comment.Mon, Feb 18, 7:07 PM

Or they could all be a bit bigger, and the snowflake versions could simply take up a teensy bit more of the snowflake's top-right corner.

Yeah I made all the Z's bigger, it should be better now

ngraham accepted this revision.Mon, Feb 18, 7:28 PM

I love it. Looks perfect to me now.

This revision is now accepted and ready to land.Mon, Feb 18, 7:28 PM
This revision was automatically updated to reflect the committed changes.