Use KF5::AuthCore instead of KF5::Auth
ClosedPublic

Authored by aacid on Feb 15 2019, 11:11 PM.

Details

Summary

It's a smaller library and provides everything needed here.

Unfortunately introduced just in KF5.56 so i will understand if you tell me to ping you back in something like 6 months :)

Diff Detail

Repository
R440 Smb4K
Branch
arcpatch-D19071
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9550
Build 9568: arc lint + arc unit
aacid requested review of this revision.Feb 15 2019, 11:11 PM
aacid created this revision.
aacid added a subscriber: Smb4K.Feb 15 2019, 11:11 PM

Sorry for answering so late. I did not have the time until now.

Since I would like to support also older versions of KF5, is there a way to use an if statement that uses KF5::AuthCore if KF5 5.56 or later is present and KF5::Auth if not? I looked at ECM, but did not find an appropriate function/macro...

Yes, that's doable, i'll do it in a bit when i find some time since this is not very urgent anyway :)

aacid updated this revision to Diff 53834.Mar 13 2019, 9:18 PM

use the best auth lib available given the kf5 you have

areinholdt accepted this revision.Mar 14 2019, 2:03 PM

Thanks for taking care of this!

This revision is now accepted and ready to land.Mar 14 2019, 2:03 PM
aacid closed this revision.Mar 14 2019, 8:40 PM