Differential D19064

Add break to fix tty information
ClosedPublic
Actions

Authored by aacid on Feb 15 2019, 10:36 PM.

Details

Reviewers
davidedmundson
Commits
R111:dcb0901e5438: Add break to fix tty information
Summary

I'm not confident i understand the code, but without the break the value of ps->setTty is always overwritten, so i guess we need this? (or otherwise we have to remove the line after case 5: altogether)

Diff Detail

Repository
R111 KSysguard Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Feb 15 2019, 10:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2019, 10:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
aacid requested review of this revision.Feb 15 2019, 10:36 PM
apol added a subscriber: apol.Feb 16 2019, 12:49 AM

+1 I'd say so too.

aacid added a comment.Feb 27 2019, 10:34 PM

If noone disagrees i'll commit this next week

davidedmundson accepted this revision.Feb 28 2019, 12:09 AM
This revision is now accepted and ready to land.Feb 28 2019, 12:09 AM
Closed by commit R111:dcb0901e5438: Add break to fix tty information (authored by aacid). · Explain WhyFeb 28 2019, 12:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mprocesscore/processes_linux_p.cpp (1 line)

Diff 52784

View Options

processcore/processes_linux_p.cpp

Loading...