Differential D19050

[sddm-theme] Change "Type User" to "Other..."
ClosedPublic
Actions

Authored by rooty on Feb 15 2019, 6:38 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R120:ed20b9e3d4c9: [sddm-theme] Change "Type User" to "Other..."
Test Plan


to

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rooty created this revision.Feb 15 2019, 6:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2019, 6:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
rooty requested review of this revision.Feb 15 2019, 6:38 PM
rooty edited the test plan for this revision. (Show Details)Feb 15 2019, 6:39 PM
rooty added reviewers: VDG, ngraham.
ngraham requested changes to this revision.Feb 15 2019, 6:40 PM

Single word-strings need context for translators. Please use i18ndc()

This revision now requires changes to proceed.Feb 15 2019, 6:40 PM
rooty updated this revision to Diff 51788.Feb 15 2019, 6:43 PM

Use i18ndc

ngraham added a comment.Feb 15 2019, 6:46 PM

Well, you have to actually add the context. :)

Like this: text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "For logging in as an arbitrary user", "Other...")

rooty added a comment.Feb 15 2019, 6:50 PM
In D19050#413024, @ngraham wrote:

Well, you have to actually add the context. :)

Like this: text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "For logging in as an arbitrary user", "Other...")

Haha my bad :D I'm not familiar with these strings at all

rooty updated this revision to Diff 51789.Feb 15 2019, 6:55 PM

Add context

rooty updated this revision to Diff 51790.Feb 15 2019, 6:55 PM

Fix typo

rooty added a comment.Feb 15 2019, 6:56 PM

is this description ok?

ngraham accepted this revision.Feb 15 2019, 6:56 PM
This revision is now accepted and ready to land.Feb 15 2019, 6:56 PM
Closed by commit R120:ed20b9e3d4c9: [sddm-theme] Change "Type User" to "Other..." (authored by rooty). · Explain WhyFeb 15 2019, 6:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msddm-theme/Main.qml (2 lines)

Diff 51791

View Options

sddm-theme/Main.qml

Loading...