In fact, long ago, when we first launched the current version, I also suggested making them flatter and all the way across the window. That way it didn't seem like it was floating.

What do we think about also changing the text color for each message to be shade of the color from the message?

Like this:

https://dribbble.com/shots/1536910-Alert-Error-Messages?utm_source=Clipboard_Shot&utm_campaign=MikeBusby&utm_content=Alert%20%2F%20Error%20Messages&utm_medium=Social_Share

In D19044#414479, @mart wrote:

-1
this has to be done at most for the desktop style and the desktop style only

Can you explain a bit more? I don't understand the technical reason for why you think we should do this in the QQC2 style only. If anything, wouldn't it make sense to not have the shadow here and only add it in the QQC2 style if we did want it there (which we don't)?

TBH, I like the shadow. Breeze as a widget theme tends to be a bit too flat. Here's how it looks with Breeze Dark.

In D19044#414530, @ngraham wrote:

In D19044#414479, @mart wrote:

-1
this has to be done at most for the desktop style and the desktop style only

Can you explain a bit more? I don't understand the technical reason for why you think we should do this in the QQC2 style only. If anything, wouldn't it make sense to not have the shadow here and only add it in the QQC2 style if we did want it there (which we don't)?

nope, not in the qqc2 style, but in the kirigami style (yes, kirigami has styles, which must have the same name as the corresponding qqc2 styles)

I would like to maintain the shadow at least with material.
this means splitting inlinemessage in a copy in templates/ and a copy in controls/ which just instantiates the one in templates and implements its background item.

then in styles/ the desktop one will have a different background with no shadow (or the base version may not have a shadow then there would be a copy in material which it would, don't care)

In D19044#412934, @abetts wrote:

In fact, long ago, when we first launched the current version, I also suggested making them flatter and all the way across the window. That way it didn't seem like it was floating.

What do we think about also changing the text color for each message to be shade of the color from the message?

Like this:

https://dribbble.com/shots/1536910-Alert-Error-Messages?utm_source=Clipboard_Shot&utm_campaign=MikeBusby&utm_content=Alert%20%2F%20Error%20Messages&utm_medium=Social_Share

The color thing looks really nice! +1

Don't fully understand the next course of action yet so if anyone wants to commandeer the revision for a speedier resolution, go ahead!

• whole InlineMessage should be moved into templates
• background: item should be deleted such that it doesn't have any background at all (lines from 123 to 173)
• in controls, an InlineMessage.qml is still present, and will be

import "templates" as T
T.InlineMessage {

background: the original background item

}

that one won't have a shadow, in styles/Material another similar one, but with the original shadow

Another important thing is to update all resource files accordingly

do you still need further explanations on the steps to do?

In D19044#416559, @mart wrote:

• whole InlineMessage should be moved into templates

Im not home right now but I ran into an issuse with this step because that file I should move to templates already imports templates and starts off with "T.InlineMessage".

In D19044#419934, @filipf wrote:

In D19044#416559, @mart wrote:

• whole InlineMessage should be moved into templates

Im not home right now but I ran into an issuse with this step because that file I should move to templates already imports templates and starts off with "T.InlineMessage".

right, it had a template already..
so hmm, some of the code in there should just go in the template to make that file simpler... then copy it

In D19044#416559, @mart wrote:

• whole InlineMessage should be moved into templates

I've been trying to do this but there's several properties such as padding and contentItem (with a big ColumnLayout attached) that depend on T.InlineMessage and I can't import that in templates. Seems I can move very little into templates so that only leaves me with adding another InlineMessage.qml for Material.

EDIT: wait, I might be onto something

can we make this massages full width borderless total flat
how can I try this in home
sorry I am new in this things

In D19044#423965, @Codezela wrote:

how can I try this in home

https://community.kde.org/Infrastructure/Phabricator#How_to_review_someone_else.27s_patch

If you need further assistance, please ask in the #kde-devel channel on IRC or Matrix.

uuh, no, this duplicates more, i meant moving things from the control to the template

In D19044#432853, @mart wrote:

uuh, no, this duplicates more, i meant moving things from the control to the template

But I moved most of things from src/controls/InlineMessage.qml to src/controls/templates/InlineMessage.qml?

In D19044#432878, @mart wrote:

In D19044#432875, @filipf wrote:

In D19044#432853, @mart wrote:

uuh, no, this duplicates more, i meant moving things from the control to the template

But I moved most of things from src/controls/InlineMessage.qml to src/controls/templates/InlineMessage.qml?

i was put off by phabricator being stupid and telling src/controls/templates/InlineMessage.qml (173 lines)
Copied to src/styles/Material/InlineMessage.qml

however yeah, it seems alright, sorry, go for it =)

No problem, thanks :)