Remove dependency on okularpart from the mobile components
ClosedPublic

Authored by vkrause on Feb 15 2019, 2:12 PM.

Details

Summary

This only depended on okularpart due to the export header used in the
kcfgc file, so use a dedicated one for the mobile components that doesn't
export anything.

This enables disabling the part build for mobile-only builds such as
Android, and thus removing the need for some difficult dependencies
like KParts.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Feb 15 2019, 2:12 PM
Restricted Application added a project: Okular. · View Herald TranscriptFeb 15 2019, 2:12 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 15 2019, 2:12 PM
aacid accepted this revision.Feb 17 2019, 7:02 PM
aacid added a subscriber: aacid.
aacid added inline comments.
mobile/components/settings.h
2

Not very happy that we need this because it means we're using "non mobile code" on the mobile client, but well, anyhow that's not new, so can't really block on it i guess :D

This revision is now accepted and ready to land.Feb 17 2019, 7:02 PM

Sure, no doubt this is super ugly and just a tiny bit better on the previous situation.
I failed to come up with an alternative that is nicer and still minimally invasive, so I'd rather try to untangle this in small steps while trying to remove Android porting scaffolding in the whole stack up to Okular.

This revision was automatically updated to reflect the committed changes.