Add 16 px and 22 px versions of the gamepad icon to devices/
ClosedPublic

Authored by rooty on Feb 15 2019, 6:49 AM.

Diff Detail

Repository
R266 Breeze Icons
Branch
gamepad-icon-16-22-px (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8425
Build 8443: arc lint + arc unit
rooty created this revision.Feb 15 2019, 6:49 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 15 2019, 6:49 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
rooty requested review of this revision.Feb 15 2019, 6:49 AM
hein added a comment.Feb 15 2019, 7:25 AM

Could this maybe be input-games-symbolic (too)? Because I want a monochrome version always (my app recolors icons using the Kirigami feature, and that only works with monochrome icons).

rooty added a comment.EditedFeb 15 2019, 12:52 PM
In D19030#412562, @hein wrote:

Could this maybe be input-games-symbolic (too)? Because I want a monochrome version always (my app recolors icons using the Kirigami feature, and that only works with monochrome icons).

In addition to or instead of -gaming?
This may also sound silly but do I link the -games icon to the folder icon or the -gaming icon :D?

+1 on input games and input-games-symbolic

rooty updated this revision to Diff 51759.Feb 15 2019, 2:46 PM

Add input-games and input-games-symbolic

Now we don't need input-gaming anymore. :)

rooty added a comment.EditedFeb 15 2019, 3:50 PM

Now we don't need input-gaming anymore. :)

@hein put the "too" in parentheses :D, I was erring on the side of caution

But what do I do with the 64 px version? Rename it to input-games? It's not a symlink.
And I have no idea where that icon's used; renaming it could break things?

ndavis added a subscriber: ndavis.Feb 15 2019, 10:16 PM
This comment was removed by ndavis.

I think the idea was that we only needed input-games and input-games-symbolic, and not also input-gaming and input-gaming-symbolic. Right?

rooty added a comment.Feb 16 2019, 9:31 PM

I think the idea was that we only needed input-games and input-games-symbolic, and not also input-gaming and input-gaming-symbolic. Right?

There already is a 64 px icon called input-gaming in master. What do I do with that icon, rename it (remove then add?)?

Oh never mind, just ignore me then. Sounds like y'all had everything under control before I started confusing everyone. :)

@hein thoughts? I'm not keen on deleting that icon, God only knows what application might be using it :D

rooty updated this revision to Diff 51890.Feb 17 2019, 5:20 AM

Use "-gamepad" instead

hein added a comment.Feb 18 2019, 1:19 PM

LGTM, thanks!

hein accepted this revision.Feb 18 2019, 1:24 PM
This revision is now accepted and ready to land.Feb 18 2019, 1:24 PM
rooty closed this revision.Feb 18 2019, 1:26 PM