The WaylandPrivate::virtualDesktopManagement object is loaded
asyncronously.
It's null until we finish fetching the registry.
A code path could call the desktopNames in that time.
Details
Details
- Reviewers
hein - Group Reviewers
Plasma - Commits
- R120:895aee564fae: Guard virtualDesktopManagement being accessed before fetched
Had a crash
Couldn't reproduce reliably
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8319 Build 8337: arc lint + arc unit
Comment Actions
The other option is:
connection->roundTrip();
at the end of init, which effectively is a (slightly safer) nested event loop until we've send a ping to kwin and back, which indicates that kwin must have also finished sending the registry
Comment Actions
It would need to be guarded if it was used.
However, from what I can tell it's not an issue there.
All API calls are to objects inside QList<KWayland::Client::PlasmaWindow*>
and if that list is empty it does nothing.