Differential D19022

actually save profiles on a fresh install
ClosedPublic
Actions

Authored by iliakats on Feb 14 2019, 8:45 PM.

Details

Reviewers
marten
Commits
R345:483c887d3b20: create profile directory if it doesn't exist
Summary

QStandardPaths::writableLocation() does not create a directory if it does not exist. Therefore, on a fresh install, kmix is trying to save channel profiles to a non-existing directory and failing miserably. This patch fixes the issue.

Diff Detail

Repository
R345 KMix
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iliakats requested review of this revision.Feb 14 2019, 8:45 PM
iliakats created this revision.
marten accepted this revision.Feb 16 2019, 8:53 AM

Not sure whether using a global static QString is the right approach - should it use Q_GLOBAL_STATIC?
On the other hand this is not library code and there is global non-POD data throughout KMix, so one more bit won't hurt.

This revision is now accepted and ready to land.Feb 16 2019, 8:53 AM
Closed by commit R345:483c887d3b20: create profile directory if it doesn't exist (authored by iliakats). · Explain WhyFeb 16 2019, 9:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgui/guiprofile.cpp (14 lines)

Diff 51841

View Options

gui/guiprofile.cpp

Loading...