Verify that model.AppPid is defined
Needs RevisionPublic

Authored by serhiyz on Feb 14 2019, 7:22 PM.

Details

Reviewers
davidedmundson
cfeck
Group Reviewers
Plasma
Summary

Verify that model.AppPid is defined to avoid error messages on every hover of a pinned launcher in Task Manager that isn't launched.

BUG: 396316

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
serhiyz created this revision.Feb 14 2019, 7:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2019, 7:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
serhiyz requested review of this revision.Feb 14 2019, 7:22 PM

In what situation is it undefined?

hein added a subscriber: hein.Feb 14 2019, 10:44 PM

Remote clients have no pid, but might be nicer to fix the model to return 0.

Only actual windows have PIDs, the role isn't implemented for startup tasks or launchers iirc

serhiyz edited the summary of this revision. (Show Details)Feb 15 2019, 12:45 PM
mart added a subscriber: mart.Feb 26 2019, 10:51 AM

+1 for fixing the model instead (0 also for startup tasks?)

cfeck requested changes to this revision.Mar 24 2019, 2:18 PM
cfeck added a subscriber: cfeck.

It was suggested to change the model (C++ code? where?) instead.

This revision now requires changes to proceed.Mar 24 2019, 2:18 PM