Differential D19013

[plasma-pa] Increase minimum size of expanded plasmoid
ClosedPublic
Actions

Authored by vpilo on Feb 14 2019, 5:03 PM.

Details

Reviewers
broulik
drosca
ngraham
Group Reviewers
Plasma
Commits
R115:6e53d78136df: [plasma-pa] Increase minimum size of expanded plasmoid
Summary

When outside of the tray, the plasmoid felt really cramped. This makes it more bearable.

Before:


After:

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vpilo created this revision.Feb 14 2019, 5:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2019, 5:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
vpilo requested review of this revision.Feb 14 2019, 5:03 PM
vpilo edited the summary of this revision. (Show Details)Feb 14 2019, 5:04 PM
vpilo added a reviewer: Plasma.
ngraham added a subscriber: ngraham.Feb 15 2019, 6:43 PM

How about even bigger? In standalone form, there's no reason to skimp on size IMO.

vpilo added a comment.Feb 15 2019, 10:00 PM
In D19013#413022, @ngraham wrote:

How about even bigger? In standalone form, there's no reason to skimp on size IMO.

Thought there was some constraint :) I'll go crazy and say 18.

vpilo updated this revision to Diff 51862.Feb 16 2019, 2:28 PM
  • Review comments
ngraham accepted this revision.Feb 16 2019, 3:25 PM
This revision is now accepted and ready to land.Feb 16 2019, 3:25 PM
Closed by commit R115:6e53d78136df: [plasma-pa] Increase minimum size of expanded plasmoid (authored by vpilo). · Explain WhyFeb 17 2019, 11:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/main.qml (10 lines)

Diff 51896

View Options

applet/contents/ui/main.qml

Loading...