Differential D19006

Use KCM name in KCM header
ClosedPublic
Actions

Authored by GB_2 on Feb 14 2019, 4:19 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10273: Make KCMs consistent and apply the KDE HIG to them as much as possible
Commits
R124:b6ad57fc5fa2: Use KCM name in KCM header
Summary

Use the KCM name in Qt Widgets KCM headers, to make them consistent with others.

Test Plan

Open a Qt Widgets KCM like "Widget Style".

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Feb 14 2019, 4:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2019, 4:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Feb 14 2019, 4:19 PM
ngraham accepted this revision.Feb 14 2019, 4:27 PM
ngraham added a subscriber: ngraham.

A clear bug. I always wondered why the QTWidgets KCMs got their header text from the comment field in the desktop file while the QML KCMs got it from the KAboutData string. +1 for always consistently using the KAboutData string.

Looks like this results in the Boot Splash KCM having an empty header. Once this lands, we need to make sure we fix that before 5.16.

This revision is now accepted and ready to land.Feb 14 2019, 4:27 PM
Closed by commit R124:b6ad57fc5fa2: Use KCM name in KCM header (authored by GB_2). · Explain WhyFeb 14 2019, 4:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcore/ModuleView.cpp (4 lines)

Diff 51695

View Options

core/ModuleView.cpp

Loading...